XDG activation support #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinorbgr
reviewed
Jul 31, 2021
anvil/src/window_map.rs
Outdated
Comment on lines
303
to
324
| pub fn bring_surface_to_top(&mut self, surface: &WlSurface) { | ||
| let found = self.windows.iter().enumerate().find(|(_, w)| { | ||
| if let Some(s) = w.toplevel.get_surface() { | ||
| s.as_ref().equals(surface.as_ref()) | ||
| } else { | ||
| false | ||
| } | ||
| }); | ||
|
|
||
| if let Some((i, _)) = found { | ||
| let winner = self.windows.remove(i); | ||
|
|
||
| // Take activation away from all the windows | ||
| for window in self.windows.iter() { | ||
| window.toplevel.set_activated(false); | ||
| } | ||
|
|
||
| // Give activation to our winner | ||
| winner.toplevel.set_activated(true); | ||
| self.windows.insert(0, winner); | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not thrilled by the code duplication with get_surface_and_bring_to_top, but I'm not quite sure how to avoid it.
There was a problem hiding this comment.
I moved the "move the nth window to top" part to a separate method, that helps a little
Co-authored-by: Victor Berger <vberger@users.noreply.github.com>
elinorbgr
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.