Fix setup install options #768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should fix #763
It will also prevent various problems detected while investigating on this issue :
ensure to pass all configuration values to the client to ensure he will not call ScopeConfig->getValue during install process. Otherwise this leads to a fatal error due to the config not being already built by Magento.
skip validation step of the reachable ES server if no parameter is submitted on the command line.
ensure useless fields are not written into the env.php
And I also decided to cover this class with unit testing.
This one is meant to be merged on 2.5 and cascaded to master.
Let me know @afoucret