[Analytics][Tracker] Feature #3340, add company_id and customer_group_id in tracking data #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to bind the click events
…er_group_id in tracking data
…g-attribute-filter-onclick-events-2.10-fix [Catalog] Fix Smile-SA#3431, replacing 'onclick' with an inline function to bind the click events
rbayet
requested changes
Nov 28, 2024
| */ | ||
| $companies = $block->getCompaniesList(); | ||
| ?> | ||
| <?php if ($block->isCompanyEnabled()): ?> |
There was a problem hiding this comment.
Should be moved above $companies
| <?php endforeach; ?> | ||
| </select> | ||
| </div> | ||
| <?php endif; ?> |
There was a problem hiding this comment.
Should be moved after the </script>
…er_group_id in tracking data
…ter performance and readability
|
Replaced by #3459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.