Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VirtualCategories] Option to force empty category if virtual category root disabled #3286

Merged

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented May 30, 2024

Work in Progress

@rbayet rbayet force-pushed the feat-force-empty-category-if-virtual-category-root-disabled branch from 771d2bb to 1b6e91d Compare May 30, 2024 10:29
@rbayet rbayet changed the title WIP: [VirtualCategories] Empty category if virtual category root disa… [VirtualCategories] Option to force empty category if virtual category root disabled May 30, 2024
@PierreGauthier PierreGauthier force-pushed the feat-force-empty-category-if-virtual-category-root-disabled branch 5 times, most recently from 3be31f6 to e5fe50f Compare June 12, 2024 15:47
@PierreGauthier PierreGauthier marked this pull request as ready for review June 12, 2024 15:48
@PierreGauthier PierreGauthier force-pushed the feat-force-empty-category-if-virtual-category-root-disabled branch from e5fe50f to 8f211ab Compare June 18, 2024 15:34
@rbayet
Copy link
Collaborator Author

rbayet commented Jun 20, 2024

We need to discuss this some more.

@PierreGauthier PierreGauthier force-pushed the feat-force-empty-category-if-virtual-category-root-disabled branch 2 times, most recently from 126dd09 to ecf0654 Compare June 24, 2024 08:10
@rbayet rbayet force-pushed the feat-force-empty-category-if-virtual-category-root-disabled branch from ecf0654 to 4171f94 Compare July 10, 2024 09:17
when the virtual category root is disabled or a disabled category is reference in a rule condition
@PierreGauthier PierreGauthier force-pushed the feat-force-empty-category-if-virtual-category-root-disabled branch from 4171f94 to d82b6ac Compare August 5, 2024 09:15
@rbayet rbayet merged commit f05e82a into 2.10.x Aug 18, 2024
9 checks passed
@rbayet rbayet deleted the feat-force-empty-category-if-virtual-category-root-disabled branch August 18, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants