Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Elasticsuite cache tag automatically. #3197

Merged

Conversation

romainruaud
Copy link
Collaborator

No description provided.

@romainruaud romainruaud added the safe to test PR can be tested label Feb 26, 2024
@rbayet
Copy link
Collaborator

rbayet commented Feb 27, 2024

Hello @romainruaud,

Isn't there another way to enable it but only once ?
As it stands, it being in a recurring profile means that if you disable it manually (once it has been enabled by running setup:upgrade) and re-run setup:upgrade (for another reason) then it's enabled again.

Basically, there is no way to forcefully disable it.

Regards,

@rbayet rbayet self-requested a review February 27, 2024 12:57
@rbayet rbayet assigned romainruaud and unassigned rbayet Feb 27, 2024
@romainruaud
Copy link
Collaborator Author

As discussed, I updated so that we'll enforce enabling the cache only if it does not exists in the current config.

@romainruaud romainruaud assigned rbayet and unassigned romainruaud Feb 28, 2024
@rbayet rbayet merged commit 84537c1 into Smile-SA:2.10.x Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test PR can be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants