Allow configurable msm for fuzzy search #3174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainruaud
force-pushed
the
fix_msm-fuzzy
branch
4 times, most recently
from
7b65329 to
ca473fd
Compare
romainruaud
force-pushed
the
fix_msm-fuzzy
branch
from
ca473fd to
177708c
Compare
|
Replaced by #3196 on 2.10.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously hardcoded to "100%", leading to some strange cases if the default minimum_should_match was not 100% but configured to something else.
Eg :
because the search with a typo triggered a fuzzy search that has an hardcoded value of 100% for minimum_should_match.