Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quality] Fixing specific PHPStan workflow sequencing #3078

Merged
merged 1 commit into from
Oct 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/02-phpstan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,6 @@ jobs:
composer-${{ matrix.php-versions }}-${{ matrix.magento-editions }}-
composer-${{ matrix.php-versions }}-

- name: "[Init] Add phpstan/phpstan"
if: steps.composer-cache.outputs.cache-hit == 'true'
working-directory: ${{ env.magento-directory }}
run: composer require --no-update --dev smile/magento2-smilelab-phpstan ^1.0

- name: "[Init] Cache Magento install"
id: magento-cache
uses: actions/cache@v2
Expand All @@ -121,6 +116,11 @@ jobs:
restore-keys: |
magento-${{ matrix.php-versions }}-${{ matrix.magento-editions }}-${{ matrix.magento-versions }}

- name: "[Init] Add phpstan/phpstan"
if: steps.composer-cache.outputs.cache-hit == 'true'
working-directory: ${{ env.magento-directory }}
run: composer require --no-update --dev smile/magento2-smilelab-phpstan ^1.0

- name: "[Init] Prepare credentials"
if: ${{env.MAGENTO_USERNAME}} != 0
run: composer config -g http-basic.repo.magento.com "$MAGENTO_USERNAME" "$MAGENTO_PASSWORD"
Expand Down