Feature refactoring relevance configuration (2.1.3 compatibility) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loading of configuration values.
…ensure compatibility with all Magento versions.
… overrided values were shown as inherited.
|
This PR replaces the #254 and targets the correct branch : 2.2.x To be merged and cascaded to 2.3.x and master. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix the backward incompatible changes made by Magento between 2.1.2 and 2.1.3 versions.
This is essentially occuring on objects inheriting or using the Magento\Framework\App\Config class (Reader, Scope pools, etc ...).
Some (slights) parts of Relevance Configuration have been refactored to be 2.1.3 compliant.
This piece of code has also been tested against a Magento 2.1.2 version and is working, which should prevent us from having to release several versions of the module in the future.
Let me know,
Best regards,