[Term Recommender] #ESP-306 Add min_doc_count in term aggregation #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coosos
reviewed
Nov 26, 2021
| /** | ||
| * Bucket min doc count filter. | ||
| * | ||
| * @return int |
Coosos
reviewed
Nov 26, 2021
| * | ||
| * @return int | ||
| */ | ||
| public function getMinDocCount() |
There was a problem hiding this comment.
Add return type to method : ?int
Coosos
reviewed
Nov 26, 2021
| @@ -48,6 +48,11 @@ class Term extends AbstractBucket | |||
| */ | |||
| private $exclude; | |||
|
|
|||
| /** | |||
| * @var int | |||
Coosos
reviewed
Nov 26, 2021
| ) { | ||
| parent::__construct($name, $field, $metrics, $childBuckets, $pipelines, $nestedPath, $filter, $nestedFilter); | ||
|
|
||
| $this->size = $size > 0 && $size < self::MAX_BUCKET_SIZE ? $size : self::MAX_BUCKET_SIZE; | ||
| $this->sortOrder = $sortOrder; | ||
| $this->include = $include; | ||
| $this->exclude = $exclude; | ||
| $this->minDocCount = $minDocCount; |
There was a problem hiding this comment.
Remove extra spaces and update the space above to be aligned
Coosos
reviewed
Nov 26, 2021
| @@ -65,6 +70,7 @@ class Term extends AbstractBucket | |||
| * @param string $sortOrder Bucket sort order. | |||
| * @param array $include Include bucket filter. | |||
| * @param array $exclude Exclude bucket filter. | |||
| * @param int $minDocCount Min doc count bucket filter. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.