Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable options for basic http authentication for Elastic Api #212

Merged
merged 5 commits into from
Nov 22, 2016

Conversation

Nielex
Copy link

@Nielex Nielex commented Nov 21, 2016

I added to possibility to use basic HTTP authentication. If you host your Elasticsearch instance on AWS or Elastic Cloud you want to use this.

I tested this for my instance on AWS and this works fine. This is related to this issue:
#211 (comment)

@afoucret
Copy link
Contributor

Hi @Nielex, we will have a look at this when we will have the time.
It's seems the build is broken because of our coding standards convention are not fully respected :

Here is an extract of the build output :

FILE: ...asticsuite/src/module-elasticsuite-core/Client/ClientFactory.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 94 | ERROR | [x] The closing brace for the class must go on the next
    |       |     line after the body
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

@Nielex
Copy link
Author

Nielex commented Nov 21, 2016

@afoucret

I fixed the error form the build output. I'll hope this will pass your tests.

@afoucret afoucret changed the base branch from master to 2.3.x November 21, 2016 16:32
@afoucret afoucret merged commit 774f221 into Smile-SA:2.3.x Nov 22, 2016
afoucret pushed a commit that referenced this pull request Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants