Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Subclasses of backend models to be indexed #1017

Merged
merged 3 commits into from
Aug 1, 2018

Conversation

superdav42
Copy link
Contributor

Some sites may have attributes with custom backend models. We should allow them to be indexed provided they extend one of the backend models we support.

Some sites may have attributes with custom backend models. We should allow them to be indexed provided they extend one of the backend models we support.
@afoucret
Copy link
Contributor

afoucret commented Jul 31, 2018

Hi @superdav42,

If you were able to fix the build, I would be able to merge this one in the master branch.

Build error detail :

FILE: .../Model/Eav/Indexer/Fulltext/Datasource/AbstractAttributeData.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 169 | ERROR | Missing blank line before return statement
----------------------------------------------------------------------
Time: 28.16 secs; Memory: 58Mb

It is mostly a code style problem.

add blank line before return statement
@superdav42
Copy link
Contributor Author

Build fixed

@afoucret afoucret merged commit f690060 into Smile-SA:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants