Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass W3C Validation #1640

Closed
yutv opened this issue Dec 12, 2019 · 1 comment
Closed

Pass W3C Validation #1640

yutv opened this issue Dec 12, 2019 · 1 comment
Labels
feature

Comments

@yutv
Copy link

yutv commented Dec 12, 2019

It would be great the elasticsuite passed the W3C validation because some clients require that.

Here are a couple errors caused by the module:

  1. Error: Element input is missing required attribute aria-expanded (source code)
  2. Warning: The type attribute is unnecessary for JavaScript resources (1, 2)

It is not a complete list, there might be more errors.
@yutv yutv added the feature label Dec 12, 2019
@rbayet
Copy link
Collaborator

rbayet commented Jan 9, 2020 •
edited
Loading

Actually, this seems like a complete list.
There are no issues related to layered navigation filters, except when having visual swatches, but that's outside our module.

@rbayet rbayet closed this as completed in 7a66f99 Jan 9, 2020
rbayet added a commit that referenced this issue Jan 9, 2020
@rbayet
Merge pull request #1642 from androshchuk/1640-fix-W3C-validatation
72635d0 
Fixes #1640 pass W3C validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yutv @rbayet