Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already pinned filter attributes not moved to their natural position after unpinning #1617

Closed
rbayet opened this issue Nov 13, 2019 · 0 comments
Assignees

Comments

@rbayet
Copy link
Collaborator

rbayet commented Nov 13, 2019

Given a category with pinned filter attributes where all attributes have the default (attribute set) position of "0", unpinning those filter attributes does not put them back at their natural position, which is determined by their attribute id.
Once unpinned, they will stay at the top of the attributes list, until the category is saved.
Once the category is reloaded, they will indeed be placed at the "natural" position, determined in that order by :

  • their position property
  • their attribute id

By opposition, an initially unpinned attribute which is pinned and then unpinned is correctly repositioned at his starting position.

Preconditions

Magento Version : 2.3.x

ElasticSuite Version : 2.8.x

Environment : Developer/Production

Third party modules : N/A

Steps to reproduce

  1. Edit a category and move 2 or 3 filters from the bottom of the attribute filters list to the top by pinning them and save the category
  2. Once the category is reloaded, unpin those attributes

Expected result

  1. The attributes should go back to the bottom of the attributes list

Actual result

  1. They stay close to the top the of attributes list, until the category is saved again
@rbayet rbayet self-assigned this Nov 13, 2019
romainruaud added a commit that referenced this issue Nov 13, 2019
…ed_back_correctly

Fixes #1617 Use attribute id as last resort order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant