Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown attributes not saved in admin in 2.2.7 #1248

Closed
JamesAllwood opened this issue Jan 7, 2019 · 4 comments
Closed

Dropdown attributes not saved in admin in 2.2.7 #1248

JamesAllwood opened this issue Jan 7, 2019 · 4 comments
Assignees
Labels

Comments

@JamesAllwood
Copy link

Ref: #1169

When adding values to attributes of either dropdown, or multi-select type in Magento admin, the values are not saved.

Preconditions

This was fixed for core 2.2.6, as mentioned in the release notes, and I've confirmed that the fix was successful, but after upgrade the Magento core to 2.2.7, the problem persists.

Magento Version : 2.2.7

ElasticSuite Version : 2.6.4

Environment : Production

Third party modules : None

Steps to reproduce

  1. Install Magento 2.2.7
  2. Install Elasticsuite 2.6.4
  3. From the admin, navigate to manage attributes, and attempt adding a new value to a attribute that's of either a dropdown type or a mult-select type
  4. Save the attribute

Expected result

  1. Page is reloaded, displaying the new value

Actual result

  1. Page is reloaded, but new value has not been saved
@rbayet
Copy link
Collaborator

rbayet commented Jan 14, 2019

Hello @JamesAllwood,

On which version CE / EE did you encounter that issue ?
Edit: reproduced on CE + Luma.

Regards,

@JamesAllwood
Copy link
Author

@rbayet - sorry, it was OpenSource (CE)

@rbayet rbayet added bug and removed needs update labels Jan 14, 2019
@rbayet
Copy link
Collaborator

rbayet commented Jan 14, 2019

@JamesAllwood np, thanks for confirming it and reporting the bug :)

rbayet added a commit to rbayet/elasticsuite that referenced this issue Jan 14, 2019
Backported changes in native JS code (catalog and swatches handling).
Removed the indentation of catalog/product/attribute/js.phtml for easier comparison.
rbayet added a commit to rbayet/elasticsuite that referenced this issue Jan 22, 2019
Swatches handling for versions prior to 2.2.6
rbayet added a commit to rbayet/elasticsuite that referenced this issue Jan 22, 2019
Backported changes in native JS code (catalog and swatches handling).
Removed the indentation of catalog/product/attribute/js.phtml for easier comparison.
rbayet added a commit to rbayet/elasticsuite that referenced this issue Jan 22, 2019
Swatches handling for versions prior to 2.2.6
rbayet added a commit to rbayet/elasticsuite that referenced this issue Jan 22, 2019
Swatches handling for versions prior to 2.2.6
rbayet added a commit to rbayet/elasticsuite that referenced this issue Jan 22, 2019
Swatches handling for versions prior to 2.2.6
rbayet added a commit to rbayet/elasticsuite that referenced this issue Jan 23, 2019
Backported changes in native JS code (catalog and swatches handling).
Removed the indentation of catalog/product/attribute/js.phtml for easier comparison.
Swatches handling for versions prior to 2.2.6
rbayet added a commit that referenced this issue Jan 23, 2019
…ues_not_saved_2_2_x

Fixes #1248 Dropdown attributes values not saved
@rbayet
Copy link
Collaborator

rbayet commented Jan 23, 2019

Non-existent issue in 2.7.x (Magento 2.3.x), so there will be no forward port there.

@rbayet rbayet closed this as completed Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants