Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Only discounted products" criteria must be updated to use offer.is_discount #5

Open
ddattee opened this issue Nov 2, 2017 · 1 comment

Comments

@ddattee
Copy link

ddattee commented Nov 2, 2017

How to reproduce
I'm trying to retreive the products from a virtual category via API.
The virtual category has been created on the "Only discounted products" criteria.

Problem
Following the recomandation found on this subject Smile-SA/elasticsuite#217.
I tried retrieving the products via the REST search API using the price.is_discount field but it doesn't work.

Reason
After diging I found that the index is made on an offer.is_discount field which is inconsistent with the field used in the Magento.

Solution
So the module needs to eather set the offer.is_discount as the field for "Only discounted products" or index on the price.is_discount field instead of the offer.is_discount.

@delyriand
Copy link
Contributor

delyriand commented Aug 22, 2018

Hi @ddattee,

Thank you for report this issue.
You are right, actually it is impossible to retrieve the product list with the criteria is_discount. We need to find a way to select the seller to apply the filter.

For the virtual category on front, we will make a quick fix to use the "Only discounted products" criteria.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants