-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New config issue format #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thec00n one of possible solution (which was discussed with Valentin) to add checker for keccak256, I will have to include python script to run this checks. |
For JS you can use Web3 -> https://web3js.readthedocs.io/en/1.0/web3-utils.html |
There are 2 configs where I change script to take first contract with |
thec00n
reviewed
Jan 24, 2019
thec00n
reviewed
Jan 24, 2019
wuestholz
reviewed
Jan 31, 2019
test_cases/integer_overflow_and_underflow/integer_overflow_benign_1.yaml
Outdated
Show resolved
Hide resolved
wuestholz
reviewed
Jan 31, 2019
test_cases/integer_overflow_and_underflow/integer_overflow_minimal.yaml
Outdated
Show resolved
Hide resolved
wuestholz
reviewed
Jan 31, 2019
test_cases/integer_overflow_and_underflow/integer_overflow_mapping_sym_1.yaml
Outdated
Show resolved
Hide resolved
wuestholz
reviewed
Jan 31, 2019
test_cases/integer_overflow_and_underflow/integer_overflow_mul.yaml
Outdated
Show resolved
Hide resolved
wuestholz
reviewed
Jan 31, 2019
test_cases/integer_overflow_and_underflow/overflow_simple_add.yaml
Outdated
Show resolved
Hide resolved
wuestholz
reviewed
Jan 31, 2019
wuestholz
reviewed
Jan 31, 2019
test_cases/write_to_arbitrary_storage_location/mapping_write.yaml
Outdated
Show resolved
Hide resolved
wuestholz
reviewed
Jan 31, 2019
wuestholz
reviewed
Feb 4, 2019
wuestholz
reviewed
Feb 4, 2019
wuestholz
reviewed
Feb 4, 2019
and ConstructorCreateArgument
…ecurity/SWC-registry into feature/new-config-format
wuestholz
approved these changes
Feb 11, 2019
ghost
removed
the
in progress
label
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will copy open question here:
I am trying to configure checker for Github SWC-registry and I wanna generate keccak256 on javascript,
I use this library: http://emn178.github.io/online-tools/keccak_256.html but it produce different output
We got bytecode string:
Which will be translated to (using http://emn178.github.io/online-tools/keccak_256.html):
eb7bbb275df9c8d7d90cf7bf2204028498a23a9c31e58dec1227d8cd34dccecd
While our config define it as:
bdb45e04caea963dec0c156b81632b1cb8970c6dd9cbacbb2bfc04770dd73895
How I get this results:
[Output] => "0xbdb45e04caea963dec0c156b81632b1cb8970c6dd9cbacbb2bfc04770dd73895"
How Valentin get this results in Go:
[Output] => "0xbdb45e04caea963dec0c156b81632b1cb8970c6dd9cbacbb2bfc04770dd73895"
But this UI show different results: http://emn178.github.io/online-tools/keccak_256.html
Whats wrong here @thec00n @wuestholz ?