Add create new task button to top of task history page #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add "Create New Task" button to `TaskList.tsx` for task creation. > > - **UI Enhancement**: > - Adds a "Create New Task" button to the top of the task history page in `TaskList.tsx`. > - Utilizes `Button`, `Link`, and `PlusIcon` components for the button design and functionality. > - Button links to the `/create` route for task creation. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c477f0b251f0db5901029a6435a9fdfbb321bf34. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a9c79d9 in 8 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/list/TaskList.tsx:19
- Draft comment:
Ensure the 'asChild' prop in the Button component is necessary. If not, consider removing it for simplicity. - Reason this comment was not posted:
Confidence changes required:33%
The header containing the 'Create New Task' button is correctly implemented, but the use of 'asChild' prop in Button component might not be necessary.
Workflow ID: wflow_Z0BBLx35e0A7nVL1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a9c79d9 in 9 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/list/TaskList.tsx:19
- Draft comment:
Ensure theButtoncomponent supports theasChildprop. If not, consider using a different approach to nest theLinkcomponent inside theButton. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_CoQ1xgqoUeEADqZn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
deleted the
salih/add-create-task-button-to-task-history-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds a "Create New Task" button to
TaskList.tsx, linking to the/createroute.TaskList.tsx.Button,Link, andPlusIconcomponents./createroute for task creation.This description was created by
for a9c79d9. It will automatically update as commits are pushed.