Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file suffix help text #994

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 17, 2024

Important

Update fileSuffix help text in types.ts to clarify automatic addition to downloaded files.

  • Help Text Update:
    • Update fileSuffix help text in helpTooltipContent in types.ts to clarify automatic addition to downloaded files.

This description was created by Ellipsis for 2296977. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Update `fileSuffix` help text in `types.ts` to clarify automatic addition to downloaded files.
>
>   - **Help Text Update**:
>     - Update `fileSuffix` help text in `helpTooltipContent` in `types.ts` to clarify that the suffix is automatically added to all downloaded files.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c886db0e3295349c20894516c541989f891b5ac7. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2296977 in 6 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts:70
  • Draft comment:
    The updated help text for fileSuffix is clear and aligns with the PR description. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR updates the help text for fileSuffix to clarify its automatic addition to downloaded files. This change aligns with the PR description and seems correct.

Workflow ID: wflow_BPoaGR9OcJZOK5DV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 2296977 in 18 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_XsB7eBYmCIKdXzzd


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -67,7 +67,7 @@ export const helpTooltipContent = {
completeOnDownload:
"Allow Skyvern to auto-complete the task when it downloads a file.",
fileSuffix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help text refers to fileSuffix, but the code uses downloadSuffix. Consider updating the help text to match the code variable name.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix that at some point

@msalihaltun msalihaltun merged commit a592d40 into main Oct 17, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/change-file-suffix-tooltip-text branch October 17, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants