Use domain while getting totp instead of url #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 6ffd306 in 16 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_M4cduQ5J1NwyBhzN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -193,7 +193,7 @@ async def _get_secret_value_from_url( | |||
|
|
|||
| # TODO (kerem): To make this more robust, we need to store the item id of the totp login item | |||
| # and use it here to get the TOTP code for that specific item | |||
| totp_command = ["bw", "get", "totp", url, "--session", session_key] | |||
| totp_command = ["bw", "get", "totp", domain, "--session", session_key] | |||
There was a problem hiding this comment.
Consider using tldextract.extract(url).registered_domain instead of tldextract.extract(url).domain to ensure the domain includes the suffix (e.g., 'example.co.uk' instead of just 'example'). This will help avoid potential conflicts with similar domain names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Change
_get_secret_value_from_url()inbitwarden.pyto usedomaininstead ofurlfor TOTP retrieval._get_secret_value_from_url()inbitwarden.pyto usedomaininstead ofurlfor TOTP retrieval.This description was created by
for 6ffd306. It will automatically update as commits are pushed.