Move navigation payload to base content #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Move `navigationPayload` field to 'base' section with toggle visibility in `CreateNewTaskForm.tsx` and `SavedTaskForm.tsx`. > > - **Behavior**: > - Move `navigationPayload` field from 'advanced' to 'base' section in `CreateNewTaskForm.tsx` and `SavedTaskForm.tsx`. > - Add toggle button to show/hide `navigationPayload` in 'base' section. > - **State Management**: > - Introduce `showAdvancedBaseContent` state to manage visibility of `navigationPayload` field in 'base' section. > - **UI**: > - Add 'Show Advanced Settings' and 'Hide Advanced Settings' buttons to toggle `navigationPayload` visibility. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 217cea7640bb6a57e44429fc3c93e6c8091a15c4. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9c32cbd in 12 seconds
More details
- Looked at
240lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:270
- Draft comment:
Consider using a consistentfontSizefor theCodeEditorcomponent across different forms for uniformity. InSavedTaskForm.tsx, thefontSizeis set to 14, while here it is 12. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions moving thenavigationPayloadfield to the 'base' section and adding toggle visibility. The implementation seems correct, but there's a minor inconsistency in theCodeEditorcomponent'sfontSizeproperty between the two files.
2. skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx:434
- Draft comment:
Consider using a consistentfontSizefor theCodeEditorcomponent across different forms for uniformity. InCreateNewTaskForm.tsx, thefontSizeis set to 12, while here it is 14. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions moving thenavigationPayloadfield to the 'base' section and adding toggle visibility. The implementation seems correct, but there's a minor inconsistency in theCodeEditorcomponent'sfontSizeproperty between the two files.
Workflow ID: wflow_cWaW7w3pfauL1zfu
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9c32cbd in 15 seconds
More details
- Looked at
240lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_OgJMmpbFrTgXqWms
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Move
navigationPayloadfield to 'base' section with toggle visibility inCreateNewTaskForm.tsxandSavedTaskForm.tsx.navigationPayloadfield from 'advanced' to 'base' section inCreateNewTaskForm.tsxandSavedTaskForm.tsx.navigationPayloadin 'base' section.showAdvancedBaseContentstate to manage visibility ofnavigationPayloadfield in 'base' section.navigationPayloadvisibility.This description was created by
for 9c32cbd. It will automatically update as commits are pushed.