Remove whitespace when blocks are renamed #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Improves node label handling by removing whitespace and ensuring uniqueness across multiple node types in the workflow editor. > > - **Behavior**: > - Replaces whitespace with underscores in node labels in `CodeBlockNode.tsx`, `DownloadNode.tsx`, and 6 other node files. > - Ensures unique labels using `getUniqueLabelForExistingNode()` in `workflowEditorUtils.ts`. > - **Functions**: > - Renames `getLabelForExistingNode()` to `getUniqueLabelForExistingNode()` in `workflowEditorUtils.ts`. > - Updates `getUniqueLabelForExistingNode()` to append underscores instead of parentheses for duplicate labels. > - **Constants**: > - Changes `NEW_NODE_LABEL_PREFIX` from `"Block "` to `"block_"` in `workflowEditorUtils.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 90514d0a30ad9081df0f97722c84d933cefe8911. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1163cf1 in 11 seconds
More details
- Looked at
248lines of code in9files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:757
- Draft comment:
The functiongetUniqueLabelForExistingNodenow appends underscores instead of using parentheses for duplicate labels. Ensure this change is consistent with the rest of the application logic. - Reason this comment was not posted:
Confidence changes required:50%
The functiongetUniqueLabelForExistingNodeis used in multiple files to ensure unique labels. However, the logic for appending underscores to create unique labels is not consistent with the previous logic of using parentheses. This change should be highlighted for consistency and clarity.
Workflow ID: wflow_CBVqcOlMivjOXuwe
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1163cf1 in 13 seconds
More details
- Looked at
248lines of code in9files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:764
- Draft comment:
The loop condition should bei <= existingLabels.length + 1to ensure all possible numbers are checked for uniqueness. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_u9hl4gci5zXV6OvA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Improves node label handling by replacing whitespace with underscores and ensuring uniqueness across multiple node types in the workflow editor.
CodeBlockNode.tsx,DownloadNode.tsx, and 6 other node files.getUniqueLabelForExistingNode()inworkflowEditorUtils.ts.getLabelForExistingNode()togetUniqueLabelForExistingNode()inworkflowEditorUtils.ts.getUniqueLabelForExistingNode()to append underscores instead of parentheses for duplicate labels.NEW_NODE_LABEL_PREFIXfrom"Block "to"block_"inworkflowEditorUtils.ts.This description was created by
for 1163cf1. It will automatically update as commits are pushed.