Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode a hover style parsing #876

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Sep 24, 2024

Important

Added a hardcoded check for hover:cursor-pointer class in isInteractable() in domUtils.js to fix a hover style bug.

  • Behavior:
    • In isInteractable() in domUtils.js, added a hardcoded check for class name hover:cursor-pointer to return true for interactability.
    • This is a temporary fix for a bug related to hover styles.

This description was created by Ellipsis for 0e44b01. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0e44b01 in 50 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/scraper/domUtils.js:464
  • Draft comment:
    Hardcoding 'hover:cursor-pointer' is not a robust solution. Consider using a more flexible approach, such as checking for a specific CSS class or using a configuration file.
  • Reason this comment was not posted:
    Based on historical feedback, this comment is too similar to comments previously marked by users as bad.

Workflow ID: wflow_85G60JqPx9S4y0tQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 7e58ebc into main Sep 24, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-hover-style-parsing branch September 24, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant