skip invisible iframe

[LawyZheng]

Important

Skip invisible iframes in get_frame_text() and get_interactable_element_tree_in_frame() to prevent scraping issues.

• Behavior:
  • Skip invisible iframes in get_frame_text() and get_interactable_element_tree_in_frame() to prevent getting stuck during frame.evaluate().
• Logging:
  • Add warning log in get_frame_text() when unable to get child_frame_element.

^{This description was created by for 33cfe1b. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 33cfe1b in 12 seconds

More details

• Looked at 35 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern/webeye/scraper/scraper.py:262

• Draft comment:
  Consider adding exception handling around await child_frame_element.is_visible() to handle potential errors or timeouts.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code checks for visibility of iframe elements before evaluating them, which is a good practice to avoid errors. However, the visibility check is done using await child_frame_element.is_visible(), which is an asynchronous call. If this call fails or takes too long, it might cause issues. It's better to handle potential exceptions around this call.

2. skyvern/webeye/scraper/scraper.py:358

• Draft comment:
  Consider adding exception handling around await frame_element.is_visible() to handle potential errors or timeouts. This applies here and in the get_frame_text function.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The same visibility check issue exists in another part of the code. It's important to handle exceptions around asynchronous calls to ensure robustness.

Workflow ID: wflow_85MCHxNz45DLqX4F

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.