Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disabled attr to element #860

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Sep 19, 2024

🚀 This description was created by 45c4285

feat: add support for disabled attribute in element processing

Summary:

Add support for disabled attribute in domUtils.js and scraper.py.

Key points:

  • Behavior:
    • Add support for disabled attribute in buildElementObject() in domUtils.js.
    • Include disabled in RESERVED_ATTRIBUTES in scraper.py for button elements.
  • Misc:
    • No changes to existing logic or other attributes.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 45c4285 in 11 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/scraper/domUtils.js:942
  • Draft comment:
    The addition of the 'disabled' attribute to the boolean conversion list is correct and consistent with similar attributes like 'readonly'.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The addition of the 'disabled' attribute to the list of attributes that are converted to boolean values is consistent with the handling of similar attributes like 'readonly' and 'aria-readonly'. This ensures that the 'disabled' attribute is correctly interpreted as a boolean in the element object.

Workflow ID: wflow_xqutmjV1zXJQpQdZ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 9a386c0 into main Sep 19, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/introduce_disabled_into_attrs branch September 19, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant