make totp_identifier parametrized in workflow

[wintonzheng]

🚀	This description was created by Ellipsis for commit 4d0fe26

feat: parameterize totp_identifier in TaskBlock

Summary:

Parameterizes totp_identifier in TaskBlock within block.py, allowing dynamic setting from workflow context.

Key points:

• Behavior:
  • totp_identifier in TaskBlock is now parameterized in block.py.
  • If totp_identifier is set and exists in the workflow context, it is updated with the context value.
  • Logs the use of parameterized totp_identifier value.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 4d0fe26 in 10 seconds

More details

• Looked at 25 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/workflow/models/block.py:243

• Draft comment:
  Consider adding a warning or error log if the TOTP identifier is expected to be parameterized but is not found in the workflow context, similar to how other parameters are handled.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code block added in the PR is checking if the TOTP identifier is parameterized and updating it accordingly. This is similar to the existing logic for URL and download_suffix. However, the code does not handle the case where the TOTP identifier is not found in the workflow context, which could lead to unexpected behavior if the identifier is expected to be parameterized but isn't.

Workflow ID: wflow_f7UGtxder4ZjgPNj

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.