Fix workflow title initial style #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit df08b02fd657cd3e807efb78e5bf7e332e433447 | |--------|--------| fix: improve workflow title editing UI with tooltip and style adjustments ### Summary: Improves workflow title editing UI with tooltip and style adjustments in `WorkflowHeader.tsx` and `EditableNodeTitle.tsx`. **Key points**: - **UI/UX Enhancements**: Added tooltip to `EditableNodeTitle` to indicate editability with message "Click to edit"; adjusted `Input` component styles to use `w-min` and `p-0` for better layout control. - **Style Adjustments**: Removed `max-w-96` from `EditableNodeTitle` to allow flexible width; added `flex-grow` to parent `div` for better layout distribution. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b0f2076 in 6 seconds
More details
- Looked at
98lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx:44
- Draft comment:
Thesize={1}attribute in theInputcomponent is unnecessary and can be removed for cleaner code. - Reason this comment was not posted:
Confidence changes required:50%
The use ofsize={1}in theInputcomponent is unnecessary and could be removed for cleaner code.
Workflow ID: wflow_a2o2h4TpCXK7ZjFA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b0f2076 in 10 seconds
More details
- Looked at
98lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/components/EditableNodeTitle.tsx:44
- Draft comment:
Thesize={1}attribute is unnecessary here as the width is dynamically set. Consider removing it for clarity. - Reason this comment was not posted:
Confidence changes required:50%
The use ofsize={1}in theInputcomponent is unnecessary and could lead to confusion. Thesizeattribute is typically used for setting the width of an input field in terms of characters, but here it seems redundant since the width is being dynamically set using JavaScript.
Workflow ID: wflow_nosPNiP3groFB66M
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: improve workflow title editing UI with tooltip and style adjustments
Summary:
Improves workflow title editing UI with tooltip and style adjustments in
WorkflowHeader.tsxandEditableNodeTitle.tsx.Key points:
EditableNodeTitleto indicate editability with message "Click to edit"; adjustedInputcomponent styles inEditableNodeTitle.tsxto usew-minandp-0for better layout control.max-w-96fromWorkflowHeader.tsxto allow flexible width; addedflex-growto parentdivinWorkflowHeader.tsxfor better layout distribution.Generated with ❤️ by ellipsis.dev