revert 'add elements to dropdown confirm prompt' #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 13dc2d0 in 15 seconds
More details
- Looked at
37lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_ULRnNu3ozHJrhoBh
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| elements=head_element.build_HTML(need_trim_element=False, need_skyvern_attrs=False), | ||
| ) | ||
| # TODO: better to send untrimmed HTML without skyvern attributes in the future | ||
| dropdown_confirm_prompt = prompt_engine.load_prompt("opened-dropdown-confirm") |
There was a problem hiding this comment.
Removing the elements from the prompt might affect the accuracy of dropdown detection. Consider if this change aligns with the intended functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reverted changes to remove HTML elements from dropdown confirmation prompt and adjusted handler function accordingly.
Key points:
skyvern/forge/prompts/skyvern/opened-dropdown-confirm.j2to remove elements from the JSON response.skyvern/webeye/actions/handler.pyto stop passing HTML elements to theopened-dropdown-confirmprompt inlocate_dropdown_menufunction.Generated with ❤️ by ellipsis.dev