Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spinbutton issue #806

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix spinbutton issue #806

merged 1 commit into from
Sep 11, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Sep 11, 2024

🚀 This description was created by Ellipsis for commit e7a4575

Summary:

Fixes spin button handling in handle_input_text_action by adding is_spinbtn_input check in SkyvernElement.

Key points:

  • Updated handle_input_text_action in skyvern/webeye/actions/handler.py to check for spin buttons using is_spinbtn_input.
  • Added is_spinbtn_input method in SkyvernElement class in skyvern/webeye/utils/dom.py to identify <input> elements with role="spinbutton".
  • Prevented clearing of spin button inputs to avoid cursor issues.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e7a4575 in 16 seconds

More details
  • Looked at 67 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/utils/dom.py:200
  • Draft comment:
    The method is_spinbtn_input is defined twice in the codebase. Consider removing the duplicate definition to avoid redundancy.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment might be valid if there is indeed another definition of is_spinbtn_input elsewhere in the codebase, but the context provided does not show this. The comment is speculative without evidence in the provided context.
    I might be missing the broader context of the entire codebase where another is_spinbtn_input method could exist. However, the comment should be based on the diff provided.
    The comment should be removed unless there is evidence in the provided context that supports the claim of a duplicate method definition.
    Remove the comment as it is speculative and not supported by the provided context.

Workflow ID: wflow_Wi0AJb9G5StOEjvi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit f429d6d into main Sep 11, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-spinbutton-issue branch September 11, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant