Deletable nodes #801
Deletable nodes #801
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit e2ea77b37bbe5ae346723ab5cd00377f746d5423 | |--------|--------| ### Summary: This PR introduces deletable nodes in the workflow editor, adding a delete node callback context, updating node components, and enhancing utility functions. **Key points**: - Introduces deletable nodes in the workflow editor. - Adds delete node callback context. - Updates node components for deletion. - Enhances utility functions for node management. - Adds `nanoid` dependency for unique ID generation. - Provides `DeleteNodeCallbackContext` for managing node deletion callbacks. - Creates `useDeleteNodeCallback` hook. - Updates `FlowRenderer` for node deletion logic. - Adds `NodeActionMenu` component for node actions. - Modifies node components to use `NodeActionMenu` and `useDeleteNodeCallback`. - Enhances `workflowEditorUtils` with `generateNodeLabel` function. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 7279f1f in 30 seconds
More details
- Looked at
911lines of code in13files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_sO05oC2ZfsSmrECO
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| return []; | ||
| } | ||
| if (edge.target === id) { | ||
| const nextEdge = edges.find((edge) => edge.source === id); |
There was a problem hiding this comment.
The logic for finding the next edge to connect when deleting a node is incorrect. It should find the edge where the source is the current node's target, not the current node's source. Consider revising this logic.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7279f1f in 31 seconds
More details
- Looked at
912lines of code in13files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_fc6koUaTe6mOWtU8
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 18ecf72 in 21 seconds
More details
- Looked at
12lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/package.json:50
- Draft comment:
Ensure that the 'nanoid' version '^5.0.7' is compatible with the rest of the dependencies and the project requirements. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the 'nanoid' dependency is correctly reflected in the package.json file. However, it's important to ensure that the version added is compatible with the rest of the dependencies and the project requirements.
Workflow ID: wflow_YuLjlbiJ3K2ukvkr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary:
This PR introduces deletable nodes in the workflow editor, updating components and adding a new dependency for unique ID generation.
Key points:
deleteNodefunction inFlowRenderer.DeleteNodeCallbackContextinskyvern-frontend/src/store/DeleteNodeCallbackContext.ts.useDeleteNodeCallbackhook inskyvern-frontend/src/routes/workflows/hooks/useDeleteNodeCallback.ts.CodeBlockNode,DownloadNode) to useNodeActionMenuanduseDeleteNodeCallback.NodeActionMenucomponent inskyvern-frontend/src/routes/workflows/editor/nodes/NodeActionMenu.tsx.workflowEditorUtilswithgenerateNodeLabelfunction.nanoiddependency for unique ID generation.Generated with ❤️ by ellipsis.dev