Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update custom selection prompt #799

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Sep 10, 2024

🚀 This description was created by Ellipsis for commit f33320b

Summary:

Refined auto-completion and selection prompt logic in Skyvern, updating JSON structures and integrating user goals and details.

Key points:

  • Updated skyvern/forge/prompts/skyvern/auto-completion-choose-option.j2 to refine auto-completion logic and JSON response structure.
  • Modified skyvern/forge/prompts/skyvern/custom-select.j2 to enhance selection logic and include user goals and details.
  • Adjusted skyvern/forge/prompts/skyvern/opened-dropdown-confirm.j2 to redefine open dropdown menu criteria.
  • Updated skyvern/webeye/actions/handler.py to integrate new prompt logic and handle additional fields for user goals and details.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f33320b in 26 seconds

More details
  • Looked at 184 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:1465
  • Draft comment:
    The condition target_value if not force_select and should_relevant else "" might lead to an empty target value being passed when it should not be. This could affect the logic that relies on the presence of a target value. Consider revising the condition to ensure target_value is correctly passed when needed.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment addresses a potential issue with the logic introduced in the diff. It suggests revising the condition to ensure the target value is correctly passed when needed. This is a valid concern as it directly relates to the changes made in the diff and could impact the functionality of the code.
    I might be overestimating the impact of the condition on the overall logic. The condition might be intentional and not necessarily an issue.
    Even if the condition is intentional, the comment highlights a potential area for improvement or clarification, which is valuable for code quality.
    The comment should be kept as it addresses a potential issue with the logic introduced in the diff and suggests a possible improvement.

Workflow ID: wflow_qGvWb2IeNQ6FxfSj


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit ddf2b32 into main Sep 10, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/update-selection-prompt branch September 10, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant