Fix the prompt cache window - use settings.PROMPT_CACHE_WINDOW_HOURS

[wintonzheng]

🚀	This description was created by Ellipsis for commit 91fd886

Summary:

Replaced hardcoded PROMPT_CACHE_WINDOW_HOURS with dynamic configuration using SettingsManager.get_settings() in generate_task, affecting skyvern/forge/sdk/routes/agent_protocol.py and skyvern/forge/sdk/db/client.py.

Key points:

• Replaced hardcoded PROMPT_CACHE_WINDOW_HOURS with SettingsManager.get_settings().PROMPT_CACHE_WINDOW_HOURS for dynamic configuration.
• Removed hardcoded value from skyvern/forge/sdk/routes/agent_protocol.py.
• Updated generate_task function to use dynamic configuration.
• Modified query_window_hours parameter in get_task_generation_by_prompt_hash.
• Changes affect skyvern/forge/sdk/db/client.py.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to b58c9f6 in 8 seconds

More details

• Looked at 22 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/routes/agent_protocol.py:777

• Draft comment:
  Ensure that SettingsManager.get_settings().PROMPT_CACHE_WINDOW_HOURS is used consistently across the codebase wherever PROMPT_CACHE_WINDOW_HOURS is needed. This ensures that any changes to the setting are reflected throughout the application.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR changes a constant to a dynamic setting retrieval, which is a good practice for flexibility. However, the change should be consistent across the codebase.

Workflow ID: wflow_NVRhF3YsYiizbTUW

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 91fd886 in 20 seconds

More details

• Looked at 35 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/forge/sdk/db/client.py:1426

• Draft comment:
  SettingsManager is not imported in this file. Add from skyvern.forge.sdk.settings_manager import SettingsManager to avoid NameError.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment seems to be incorrect because the code change is related to a setting name change, not an issue with SettingsManager. The import for settings is already present, and there is no indication that SettingsManager is needed. The comment does not address a change made in the diff.
  I might be missing some context about SettingsManager if it is used elsewhere in the file, but the comment should only address changes made in the diff. The comment does not seem relevant to the change made.
  The comment is not relevant to the specific change made in the diff, which is a setting name change. There is no indication that SettingsManager is needed for this change.
  The comment about importing SettingsManager is not relevant to the change made in the diff and should be removed.

Workflow ID: wflow_F8Nfjb29OXkUUsVj

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.