Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribe element classname change #766

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Sep 3, 2024

🚀 This description was created by Ellipsis for commit e7e5c14

Summary:

Enhanced skyvern/webeye/scraper/domUtils.js to detect visibility changes in elements based on class name updates, updating global state accordingly.

Key points:

  • Added isClassNameIncludesHidden function in skyvern/webeye/scraper/domUtils.js to check if a class name includes 'hide'.
  • Updated MutationObserver to handle class attribute changes, specifically to detect when elements become visible.
  • Modified logic to add elements to window.globalOneTimeIncrementElements and window.globalDomDepthMap when class changes make them visible.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e7e5c14 in 10 seconds

More details
  • Looked at 45 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/scraper/domUtils.js:1640
  • Draft comment:
    The function isClassNameIncludesHidden is defined but not used anywhere in the codebase. Consider removing it if it's not needed or ensure it's used where intended.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The function isClassNameIncludesHidden is not used anywhere in the codebase. This might be an oversight or the function might be intended for future use.

Workflow ID: wflow_IqPMWVxANFQcWcEh


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 320cf44 into main Sep 3, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/subscribe-class-name-change branch September 3, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant