Add images for new templates #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `purchasingImage` and `entityLookupImage` to `TemporaryTemplateImages.ts` with specific template IDs. > > - **Images**: > - Add `purchasingImage` and `entityLookupImage` imports in `TemporaryTemplateImages.ts`. > - Associate `purchasingImage` with `wpid_357290139535158898` and `entityLookupImage` with `wpid_357290367168425660` in `TEMPORARY_TEMPLATE_IMAGES`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 40a279869c8d337de240fb9076067acfe5d6bc00. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b6d6ede in 22 seconds
More details
- Looked at
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:3
- Draft comment:
Ensure that purchasing.png and entity-lookup.png assets exist at the specified paths. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:3
- Draft comment:
Confirm that 'purchasing.png' exists at '@/assets/purchasing.png'. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:4
- Draft comment:
Confirm that 'entity-lookup.png' exists at '@/assets/entity-lookup.png'. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:10
- Draft comment:
Verify that template ID 'wpid_357290139535158898' is correctly mapped to purchasingImage. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
5. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:11
- Draft comment:
Verify that template ID 'wpid_357290367168425660' is correctly mapped to entityLookupImage. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_QLhX3zU3MQIx0KnC
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b6d6ede in 18 seconds
More details
- Looked at
17lines of code in1files - Skipped
2files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:3
- Draft comment:
Verify '@/assets/purchasing.png' exists and is optimized for web usage. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
2. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:4
- Draft comment:
Ensure '@/assets/entity-lookup.png' exists and matches naming conventions. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
3. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:3
- Draft comment:
Good import of purchasingImage. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:4
- Draft comment:
Entity lookup image import looks correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
5. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:10
- Draft comment:
Mapping new template ID to purchasingImage is as expected. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
6. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:11
- Draft comment:
Mapping new template ID to entityLookupImage is proper. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_mzbNwtVceFmTg8T9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add new images for templates in
TemporaryTemplateImages.ts.purchasing.pngandentity-lookup.pngto imports inTemporaryTemplateImages.ts.purchasingImageandentityLookupImagetoTEMPORARY_TEMPLATE_IMAGESwith keyswpid_357290139535158898andwpid_357290367168425660.This description was created by
for b6d6ede. It will automatically update as commits are pushed.