Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tooltip (as title) on add parameter #1511

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 7, 2025

Important

Add tooltip to 'Add a parameter' button in WorkflowBlockInput.tsx and WorkflowBlockInputTextarea.tsx.

  • UI Enhancement:
    • Add title="Add a parameter" to the div containing PlusIcon in WorkflowBlockInput.tsx and WorkflowBlockInputTextarea.tsx to provide a tooltip.

This description was created by Ellipsis for bc57794. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Add tooltip to 'Add a parameter' button in `WorkflowBlockInput.tsx` and `WorkflowBlockInputTextarea.tsx`.
>
>   - **UI Enhancement**:
>     - Add `title="Add a parameter"` to the `div` containing `PlusIcon` in `WorkflowBlockInput.tsx` and `WorkflowBlockInputTextarea.tsx` to provide a tooltip.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 22c9ca3d3ff60e590aee8bd4714df60bb798f772. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on bc57794 in 13 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/components/WorkflowBlockInput.tsx:27
  • Draft comment:
    Consider using a more descriptive tooltip text, such as "Click to add a new parameter" for better user guidance. This applies to WorkflowBlockInputTextarea.tsx as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR correctly adds a tooltip to the div containing the PlusIcon in both files. However, the tooltip text could be more descriptive to enhance user experience.

Workflow ID: wflow_uKiaJ788OwDj10al


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bc57794 in 17 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern-frontend/src/components/WorkflowBlockInput.tsx:27
  • Draft comment:
    The addition of title="Add a parameter" is a good enhancement for accessibility and user guidance.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds a tooltip to the div containing the PlusIcon, which is a straightforward UI enhancement. The implementation is correct and follows the description provided in the PR.
2. skyvern-frontend/src/components/WorkflowBlockInputTextarea.tsx:30
  • Draft comment:
    The addition of title="Add a parameter" is a good enhancement for accessibility and user guidance.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds a tooltip to the div containing the PlusIcon, which is a straightforward UI enhancement. The implementation is correct and follows the description provided in the PR.

Workflow ID: wflow_IPbhwwDlAoryWnsT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit ddc934a into main Jan 7, 2025
2 checks passed
@msalihaltun msalihaltun deleted the salih/add-tooltip-on-plus branch January 7, 2025 15:41
satansdeer pushed a commit to satansdeer/skyvern that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants