Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix forloop output parameter issue #1490

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Jan 5, 2025

Important

Fixes output parameter handling in execute_loop_helper in block.py by setting output_value to None if not present in workflow_run_context.

  • Behavior:
    • Fixes issue in execute_loop_helper in block.py where output_value is now set to None if workflow_run_context does not have the output_parameter.key.
  • Error Handling:
    • Adds error handling for missing output_parameter values in loop execution, preventing potential errors when values are not set.

This description was created by Ellipsis for 49e9ee0. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 49e9ee0 in 10 seconds

More details
  • Looked at 30 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:851
  • Draft comment:
    Ensure that the get_value method is safe to call without checking has_value first, or else this pattern should be used consistently throughout the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the PR ensures that if the workflow_run_context does not have a value for the output parameter key, None is returned instead of causing an error. This is a good practice to prevent potential runtime errors when accessing keys that might not exist.

Workflow ID: wflow_WPfELXG2MGPAylPN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 240b75c into main Jan 5, 2025
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-for-loop-output-parameter-issue branch January 5, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant