Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workflow ouput order #1473

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix workflow ouput order #1473

merged 1 commit into from
Jan 3, 2025

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Jan 3, 2025

Important

Fixes iteration order in get_output_parameter_workflow_run_output_parameter_tuples() in service.py.

  • Behavior:
    • Fixes the order of iteration in get_output_parameter_workflow_run_output_parameter_tuples() in service.py to iterate over workflow_run_output_parameters first, then output_parameters.

This description was created by Ellipsis for 11479a7. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 11479a7 in 10 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:731
  • Draft comment:
    The order of iteration in the nested loop has been changed. Ensure this change aligns with the intended logic and does not introduce any logical errors. The new order iterates over workflow_run_output_parameters first, which might be more efficient or correct depending on the data structure sizes or the logic required.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the PR modifies the order of iteration in a nested loop. This change is likely intended to optimize the order of operations or to fix a logical issue with the previous order. The new order iterates over workflow_run_output_parameters first, which might be more efficient or correct depending on the data structure sizes or the logic required.

Workflow ID: wflow_NMyGDVGh4BpkGF5B


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit c9c97fb into main Jan 3, 2025
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-workflow-output-order branch January 3, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant