Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add screenshot for the first task block #1471

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 3, 2025

Important

Adds screenshot capture for the first task block in execute() in block.py.

  • Behavior:
    • Adds screenshot capture for the first task block in execute() in block.py.
    • Screenshot is taken using browser_state.take_screenshot(full_page=True) and stored as an artifact with type ArtifactType.SCREENSHOT_LLM.
  • Error Handling:
    • Logs exception if browser state retrieval fails for the first task.

This description was created by Ellipsis for 1d8be91. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1d8be91 in 42 seconds

More details
  • Looked at 28 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:458
  • Draft comment:
    Duplicate screenshot logic. The same screenshot logic is already present in execute_safe. Consider removing one to avoid redundancy.
  • Reason this comment was not posted:
    Based on historical feedback, this comment is too similar to comments previously marked by users as bad.

Workflow ID: wflow_2pFUefXW9KzOsOXg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 241f648 into main Jan 3, 2025
2 checks passed
@wintonzheng wintonzheng deleted the shu/add_screenshot_for_the_first_task_block branch January 3, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant