Link to task diagnostics in block card #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/'
<!-- ELLIPSIS_HIDDEN -->
> [!IMPORTANT]
> Adds a link to task diagnostics in `BlockCard` using `ExternalLinkIcon` and `Link` if `task_id` is present.
>
> - **Behavior**:
> - Adds a link to task diagnostics in `BlockCard` if `block.task_id` is present.
> - Uses `ExternalLinkIcon` and `Link` from `react-router-dom` to navigate to `/tasks/{task_id}/diagnostics`.
> - **UI Components**:
> - Replaces `CubeIcon` with `ExternalLinkIcon` in `BlockCard`.
> - Adds `Button` component to wrap the `Link` for better styling and interaction.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 88b9c999bf305ad38cec82b24bd1bde8f8122c53. It will automatically update as commits are pushed.</sup>
<!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 6f53e0d in 10 seconds
More details
- Looked at
48lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/BlockCard.tsx:38
- Draft comment:
Verify ifsize="icon"is a valid prop for theButtoncomponent. If not, adjust to a valid size. - Reason this comment was not posted:
Confidence changes required:50%
TheButtoncomponent is used withasChildprop, which is correct for wrapping theLinkcomponent. However, thesizeprop is set toicon, which might not be a valid size for theButtoncomponent. This should be verified in theButtoncomponent's implementation.
Workflow ID: wflow_lPxVMjobTjX85zzb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6f53e0d in 10 seconds
More details
- Looked at
48lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/BlockCard.tsx:37
- Draft comment:
TheasChildprop in theButtoncomponent is non-standard and might not be supported. Verify if it's necessary or remove it. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_ACvO5hfQVGWwVGkJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds a link to task diagnostics in
BlockCardusingExternalLinkIconandLinkiftask_idis present.BlockCardifblock.task_idis present.ExternalLinkIconandLinkto navigate to/tasks/{task_id}/diagnostics.CubeIconwithExternalLinkIconinBlockCard.LinkinButtonfor improved styling and interaction.This description was created by
for 6f53e0d. It will automatically update as commits are pushed.