fix non-link loop values in observer #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Fix handling of non-link loop values in `_generate_loop_task()` in `observer_service.py` by ensuring `ContextParameter` is created for both link and non-link loop values. > > - **Behavior**: > - Fix handling of non-link loop values in `_generate_loop_task()` in `observer_service.py` by ensuring `ContextParameter` is created for both link and non-link loop values. > - **Logging**: > - Remove redundant logging of "Workflow found" in `run_observer_cruise_helper()` in `observer_service.py`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b116f2feeb339f966803cf5e7152e78079928211. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0573a72 in 10 seconds
More details
- Looked at
59lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/observer_service.py:759
- Draft comment:
The code for creatingContextParameterand appending it totask_parametersandfor_loop_parameter_yaml_listis duplicated. Consider refactoring to avoid redundancy. - Reason this comment was not posted:
Confidence changes required:50%
The PR correctly refactors the code to handle both link and non-link loop values. However, the code for creatingContextParameterand appending it totask_parametersandfor_loop_parameter_yaml_listis duplicated. This can be refactored to avoid redundancy.
Workflow ID: wflow_vkeUYtNBIpTmz5cm
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0573a72 in 14 seconds
More details
- Looked at
59lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern/forge/sdk/services/observer_service.py:282
- Draft comment:
Consider removing the 'Workflow run found' logging statement as it might be redundant, similar to the 'Workflow found' log that was removed. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions removing redundant logging, and the code change reflects that. However, the logging statement for 'Workflow run found' is still present, which might also be considered redundant.
2. skyvern/forge/sdk/services/observer_service.py:746
- Draft comment:
Good refactoring to ensureContextParameteris created for both link and non-link loop values, improving consistency. - Reason this comment was not posted:
Confidence changes required:0%
The refactoring in the PR ensures thatContextParameteris created for both link and non-link loop values, which is a good practice for consistency and maintainability.
Workflow ID: wflow_TNDBSTcgEHrrHMML
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fix handling of non-link loop values in
_generate_loop_task()and remove redundant logging inobserver_service.py._generate_loop_task()inobserver_service.pyby ensuringContextParameteris created for both link and non-link loop values.run_observer_cruise_helper()inobserver_service.py.This description was created by
for 0573a72. It will automatically update as commits are pushed.