Fix overflow in workflow run timeline #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Fixes UI overflow and adds unique keys to React components in workflow run timeline. > > - **UI Fixes**: > - Adjust `max-h` from `42rem` to `40rem` in `WorkflowRunOverview.tsx` to fix overflow issue. > - **React Key Fixes**: > - Add `key` prop to `WorkflowRunTimelineBlockItem` in `WorkflowRunTimelineBlockItem.tsx` for unique identification of mapped components. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c0719d9b2b16d35c22559f8fba0220dcbd2d815c. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0893445 in 11 seconds
More details
- Looked at
26lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimelineBlockItem.tsx:48
- Draft comment:
Thekeyprop is correctly set toblock.workflow_run_block_idto ensure uniqueness among sibling components. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions adding unique keys to React components, and the code changes reflect this. Thekeyprop is correctly added to theWorkflowRunTimelineBlockItemcomponent in theWorkflowRunTimelineBlockItem.tsxfile. The key is set toblock.workflow_run_block_id, which is appropriate for ensuring uniqueness among sibling components.
Workflow ID: wflow_BbHSJdY5emNqHeeP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0893445 in 12 seconds
More details
- Looked at
26lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimelineBlockItem.tsx:48
- Draft comment:
Ensureblock.workflow_run_block_idis unique among sibling components to avoid React key collision issues. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions adding unique keys to React components, and the code changes reflect this. However, there is a potential issue with the key usage in theWorkflowRunTimelineBlockItem.tsxfile. Thekeyprop should be unique among siblings, and whileblock.workflow_run_block_idis likely unique, it's important to ensure this is the case. Additionally, thekeyprop forActionCardusesaction.action_id, which should also be verified for uniqueness.
Workflow ID: wflow_pADg9GH0AmQHlKzY
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes UI overflow and adds unique keys to React components in workflow run timeline.
max-hfrom42remto40reminWorkflowRunOverview.tsxto fix overflow issue.keyprop toWorkflowRunTimelineBlockIteminWorkflowRunTimelineBlockItem.tsxfor unique identification of mapped components.This description was created by
for 0893445. It will automatically update as commits are pushed.