Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add navigation_payload to workflow run block #1428

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 23, 2024

Important

Add navigation_payload to WorkflowRunBlock and update convert_to_workflow_run_block to handle it.

  • Behavior:
    • Add navigation_payload to WorkflowRunBlock in workflow_runs.py.
    • Update convert_to_workflow_run_block in utils.py to set navigation_payload from task.navigation_payload if task is provided.

This description was created by Ellipsis for d6ca363. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d6ca363 in 8 seconds

More details
  • Looked at 25 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/schemas/workflow_runs.py:27
  • Draft comment:
    Consider specifying the type of elements in the list for navigation_payload if possible, to avoid unexpected types being assigned.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds a new field navigation_payload to the WorkflowRunBlock class and updates the convert_to_workflow_run_block function to set this field. This change seems consistent and correct, but there is a potential issue with the type hint for navigation_payload. The type hint includes list, which is not specific enough and could lead to unexpected types being assigned. It would be better to specify the type of elements in the list if possible.

Workflow ID: wflow_eba9WMAHYGfJRJPh


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 501ab7f into main Dec 23, 2024
2 checks passed
@wintonzheng wintonzheng deleted the add_navigation_payload_to_task_run_blocks branch December 23, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant