Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend user goal check with complete criterion #1382

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Dec 13, 2024

Important

Extend user goal verification by incorporating a 'complete criterion' in agent.py and check-user-goal.j2.

  • Behavior:
    • Extend complete_verify in agent.py to include complete_criterion in the verification prompt.
    • Update check-user-goal.j2 to conditionally include complete_criterion in the prompt and JSON response.
  • Prompts:
    • Modify check-user-goal.j2 to append complete_criterion details if available.

This description was created by Ellipsis for a664b6b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a664b6b in 22 seconds

More details
  • Looked at 50 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/check-user-goal.j2:1
  • Draft comment:
    Ensure complete_criterion is defined in the context where this template is used to avoid runtime errors.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_iBmgOyhDHmvZeUp2


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 01c28e9 into main Dec 13, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/extend-user-goal-check branch December 13, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant