refactor loopblock value #1379
Merged
refactor loopblock value #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to d8735c2 in 13 minutes and 23 seconds
More details
- Looked at
199lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:754
- Draft comment:
Consider including the exception message in the failure reason to provide more context on the error. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_e8ITv9lbVZwe5xw0
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| ) | ||
| except Exception as e: | ||
| raise FailedToFormatJinjaStyleParameter(value_template, str(e)) | ||
| parameter_value = json.loads(value_json) |
There was a problem hiding this comment.
Consider adding exception handling for json.loads to manage potential JSON parsing errors gracefully.
| loop_over_parameter = parameters[trimmed_key] | ||
|
|
||
| if loop_over_parameter is None and not block_yaml.loop_variable_reference: | ||
| raise Exception("empty loop value parameter") |
There was a problem hiding this comment.
Consider raising a more specific exception instead of a generic Exception for better error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Refactor loop block value handling by introducing
loop_variable_referenceand updating related logic inForLoopBlock, YAML, and service components.FailedToFormatJinjaStyleParameterandNoIterableValueFoundinexceptions.py.loop_variable_referenceattribute inblock.py.get_loop_over_parameter_values()to handleloop_variable_reference.execute()to handle exceptions fromget_loop_over_parameter_values().loop_variable_referencetoForLoopBlockYAMLinyaml.py.block_yaml_to_block()inservice.pyto handleloop_variable_reference.This description was created by
for d8735c2. It will automatically update as commits are pushed.