-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use popover in add parameter experience #1377
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Refactor parameter addition UI in node components by integrating a popover-based interface for a consistent user experience. > > - **UI Enhancement**: > - Integrate `Popover` for parameter addition in `WorkflowBlockInput` and `WorkflowBlockInputTextarea`. > - Replace `onIconClick` with `PopoverTrigger` in `WorkflowBlockInput` and `WorkflowBlockInputTextarea`. > - **Node Components**: > - Update `ActionNode`, `ExtractionNode`, `FileDownloadNode`, `LoginNode`, `NavigationNode`, `TaskNode`, and `ValidationNode` to use `Popover` for parameter selection. > - Remove `parametersPanelField` state and related logic from node components. > - **Parameter Selection**: > - Modify `WorkflowBlockParameterSelect` to remove `onClose` prop and adjust layout for popover usage. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 36cb5ae370ae1f4717d62406794ddd51523b8577. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on f58fa79 in 23 seconds
More details
- Looked at
993
lines of code in10
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowBlockParameterSelect.tsx:80
- Draft comment:
The?.
operator is unnecessary here sinceonAdd
is a required prop and will always be defined. Remove the?.
for clarity. - Reason this comment was not posted:
Confidence changes required:50%
TheonAdd
function is called with a parameter key, but the?.
operator is unnecessary sinceonAdd
is a required prop and will always be defined. This is a minor issue but should be corrected for clarity and consistency.
Workflow ID: wflow_W0CINBsQY5WL5oHD
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to f58fa79 in 28 seconds
More details
- Looked at
993
lines of code in10
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. skyvern-frontend/src/components/WorkflowBlockInput.tsx:35
- Draft comment:
Ensureprops.value
is up-to-date before using it in theonAdd
callback to avoid potential issues with stale values. - Reason this comment was not posted:
Confidence changes required:50%
TheonAdd
function is called with a parameter key, but theprops.value
is not updated before using it in theonAdd
callback. This could lead to incorrect values being used ifprops.value
is not up-to-date.
2. skyvern-frontend/src/components/WorkflowBlockInputTextarea.tsx:38
- Draft comment:
Ensureprops.value
is up-to-date before using it in theonAdd
callback to avoid potential issues with stale values. - Reason this comment was not posted:
Confidence changes required:50%
TheonAdd
function is called with a parameter key, but theprops.value
is not updated before using it in theonAdd
callback. This could lead to incorrect values being used ifprops.value
is not up-to-date.
Workflow ID: wflow_yDKBGbKeHff5peD9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Refactor parameter addition UI in node components by integrating a popover-based interface for a consistent user experience.
Popover
for parameter addition inWorkflowBlockInput
andWorkflowBlockInputTextarea
.onIconClick
withPopoverTrigger
inWorkflowBlockInput
andWorkflowBlockInputTextarea
.ActionNode
,ExtractionNode
,FileDownloadNode
to usePopover
for parameter selection.parametersPanelField
state and related logic from node components.WorkflowBlockParameterSelect
to removeonClose
prop and adjust layout for popover usage.This description was created by for f58fa79. It will automatically update as commits are pushed.