Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use popover in add parameter experience #1377

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 12, 2024

Important

Refactor parameter addition UI in node components by integrating a popover-based interface for a consistent user experience.

  • UI Enhancement:
    • Integrate Popover for parameter addition in WorkflowBlockInput and WorkflowBlockInputTextarea.
    • Replace onIconClick with PopoverTrigger in WorkflowBlockInput and WorkflowBlockInputTextarea.
  • Node Components:
    • Update ActionNode, ExtractionNode, FileDownloadNode to use Popover for parameter selection.
    • Remove parametersPanelField state and related logic from node components.
  • Parameter Selection:
    • Modify WorkflowBlockParameterSelect to remove onClose prop and adjust layout for popover usage.

This description was created by Ellipsis for f58fa79. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Refactor parameter addition UI in node components by integrating a popover-based interface for a consistent user experience.
>
>   - **UI Enhancement**:
>     - Integrate `Popover` for parameter addition in `WorkflowBlockInput` and `WorkflowBlockInputTextarea`.
>     - Replace `onIconClick` with `PopoverTrigger` in `WorkflowBlockInput` and `WorkflowBlockInputTextarea`.
>   - **Node Components**:
>     - Update `ActionNode`, `ExtractionNode`, `FileDownloadNode`, `LoginNode`, `NavigationNode`, `TaskNode`, and `ValidationNode` to use `Popover` for parameter selection.
>     - Remove `parametersPanelField` state and related logic from node components.
>   - **Parameter Selection**:
>     - Modify `WorkflowBlockParameterSelect` to remove `onClose` prop and adjust layout for popover usage.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 36cb5ae370ae1f4717d62406794ddd51523b8577. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on f58fa79 in 23 seconds

More details
  • Looked at 993 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowBlockParameterSelect.tsx:80
  • Draft comment:
    The ?. operator is unnecessary here since onAdd is a required prop and will always be defined. Remove the ?. for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The onAdd function is called with a parameter key, but the ?. operator is unnecessary since onAdd is a required prop and will always be defined. This is a minor issue but should be corrected for clarity and consistency.

Workflow ID: wflow_W0CINBsQY5WL5oHD


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f58fa79 in 28 seconds

More details
  • Looked at 993 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. skyvern-frontend/src/components/WorkflowBlockInput.tsx:35
  • Draft comment:
    Ensure props.value is up-to-date before using it in the onAdd callback to avoid potential issues with stale values.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The onAdd function is called with a parameter key, but the props.value is not updated before using it in the onAdd callback. This could lead to incorrect values being used if props.value is not up-to-date.
2. skyvern-frontend/src/components/WorkflowBlockInputTextarea.tsx:38
  • Draft comment:
    Ensure props.value is up-to-date before using it in the onAdd callback to avoid potential issues with stale values.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The onAdd function is called with a parameter key, but the props.value is not updated before using it in the onAdd callback. This could lead to incorrect values being used if props.value is not up-to-date.

Workflow ID: wflow_yDKBGbKeHff5peD9


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 3b8b963 into main Dec 12, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/use-popover-in-add-parameter branch December 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants