Fix a bug with task fields #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Fixes bug in `TaskNode.tsx` by correctly handling `onChange` events for `url` and `navigationGoal` fields. > > - **Behavior**: > - Fixes bug in `TaskNode.tsx` where `onChange` handlers for `url` and `navigationGoal` fields were not correctly extracting values from `event.target.value`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for f24ce980a1717a8d2f99b36d310838088eff30a1. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0faeb77 in 9 seconds
More details
- Looked at
26lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:129
- Draft comment:
The onChange handler now correctly extracts the value from event.target.value, fixing the previous bug. - Reason this comment was not posted:
Confidence changes required:0%
The PR fixes the onChange handlers for 'url' and 'navigationGoal' fields to correctly extract values from event.target.value. This is a necessary fix as the previous implementation was incorrect.
Workflow ID: wflow_gUJuaLeM4YCj7soL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0faeb77 in 10 seconds
More details
- Looked at
26lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:129
- Draft comment:
The change to useevent.target.valuein theonChangehandler is correct and necessary for handling input events in React. This pattern is used consistently throughout the file. - Reason this comment was not posted:
Confidence changes required:0%
The PR correctly changes the onChange handlers to use event.target.value, which is necessary for handling input events in React. This is a common pattern and aligns with best practices.
Workflow ID: wflow_HNoQqWR1cExMSzF5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes bug in
TaskNode.tsxby correctly handlingonChangeevents forurlandnavigationGoalfields.TaskNode.tsxwhereonChangehandlers forurlandnavigationGoalfields were not correctly extracting values fromevent.target.value.This description was created by
for 0faeb77. It will automatically update as commits are pushed.