Change file names to file 1,2,3.. for now #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Renames file URLs to `File 1`, `File 2`, etc., in `WorkflowRun.tsx` for improved UI clarity. > > - **UI Changes**: > - In `WorkflowRun.tsx`, file URLs are now displayed as `File 1`, `File 2`, etc., instead of the full URL. > - Adds `title` attribute to the file link div to retain the full URL for hover display. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for bfa98d83caa143e1fb46f11cabef0bee118c127c. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1b6ef42 in 8 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:640
- Draft comment:
Usingurlas a key might not be ideal if URLs can change or be duplicated. Consider usingindexor another unique identifier. - Reason this comment was not posted:
Confidence changes required:50%
The key for the map function should be unique and stable. Using the URL as a key might not be ideal if URLs can change or be duplicated.
Workflow ID: wflow_QP6r1ECe3EMzbbgr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1b6ef42 in 21 seconds
More details
- Looked at
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:640
- Draft comment:
Using the URL as a key might lead to issues if URLs are not unique. Consider using the index as a key instead. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_LjcuAaaGzwaBMEgZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Renames file URLs to
File 1,File 2, etc., inWorkflowRun.tsxfor improved UI clarity.WorkflowRun.tsx, file URLs are now displayed asFile 1,File 2, etc., instead of the full URL.titleattribute to the file link div to retain the full URL for hover display.This description was created by
for 1b6ef42. It will automatically update as commits are pushed.