Skyvern Forms UI

[wintonzheng]

Important

This PR adds new UI components for form management, updates routing, and refactors task management in Skyvern.

• New Features:
  • Adds FormsPage, FormsPageLayout, and FormsRunHistory for form management.
  • Introduces ComingSoonPage for future features like Jobs, Invoices, Purchasing, and Government.
• Routing:
  • Updates router.tsx to include new routes for forms and upcoming features.
  • Changes default navigation to /tasks instead of /create.
• UI Components:
  • Adds NavLinkGroup and StatusFilterDropdown for navigation and filtering.
  • Introduces new icons: BagIcon, GovernmentIcon, ReceiptIcon, ToolIcon.
• Task Management:
  • Refactors CreateNewTaskForm, RetryTask, and TaskDetails to support new form features.
  • Updates TaskHistory and TasksPage for new filtering and navigation options.
• Miscellaneous:
  • Updates Header and SideNav for improved navigation and external links.
  • Modifies CreateTaskRequest type to include optional fields.

^{This description was created by for 1176f0e. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Incremental review on 1176f0e in 1 minute and 6 seconds

More details

• Looked at 1017 lines of code in 18 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. skyvern-frontend/src/api/types.ts:95

• Draft comment:
  The CreateTaskRequest type has been updated to make several fields optional. Ensure that the createTaskRequestObject function reflects these changes by making fields optional where necessary.
• Reason this comment was not posted:
  Comment did not seem useful.

2. skyvern-frontend/src/components/StatusFilterDropdown.tsx:34

• Draft comment:
  Ensure that Status values are unique since item.value is used as a key. This is important to avoid potential issues with key uniqueness.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The StatusFilterDropdown component uses item.value as a key, which is fine as long as Status values are unique. Ensure that Status values are unique to avoid potential issues.

3. skyvern-frontend/src/routes/tasks/list/TaskHistory.tsx:116

• Draft comment:
  Ensure that task_id is unique since it is used as a key. This is important to avoid potential issues with key uniqueness.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The TaskHistory component uses task.task_id as a key, which is appropriate if task_id is unique. Ensure that task_id is unique to avoid potential issues.

Workflow ID: wflow_ndVhj618H71UvAIl

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Using link.to as a key might not be unique if the same route is used multiple times. Consider using a combination of link.to and link.label or another unique identifier.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 1176f0e in 1 minute and 34 seconds

More details

• Looked at 1019 lines of code in 18 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:89

• Draft comment:
  The title field is optional in CreateTaskRequest, so assigning null here is unnecessary. Consider removing this assignment.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The CreateTaskRequest type has been updated to make several fields optional, but the createTaskRequestObject function in CreateNewTaskForm.tsx still assigns null to some fields. This is unnecessary since the fields are already optional.

2. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:19

• Draft comment:
  The useToast import is unused and can be removed to clean up the code.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The useToast hook is imported but not used in CreateNewTaskForm.tsx. This is likely a leftover from a previous implementation and should be removed to clean up the code.

3. skyvern-frontend/src/router.tsx:36

• Draft comment:
  Ensure that all references to TaskList are updated to TasksPage to avoid any broken imports or references.
• Reason this comment was not posted:
  Confidence changes required: 30%
  The TaskList component has been removed and replaced with TasksPage. Ensure that all references to TaskList are updated to TasksPage to avoid any broken imports or references.

4. skyvern-frontend/src/router.tsx:33

• Draft comment:
  Ensure that all references to TaskList are updated to TasksPage to avoid any broken imports or references.
• Reason this comment was not posted:
  Confidence changes required: 30%
  The TaskList component has been removed and replaced with TasksPage. Ensure that all references to TaskList are updated to TasksPage to avoid any broken imports or references.

Workflow ID: wflow_y3QuXhl7US7of3OR

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.