Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default PRESIGNED_URL_EXPIRATION 24 hours #1309

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 3, 2024

Important

Add default PRESIGNED_URL_EXPIRATION of 24 hours to Settings in config.py.

  • Configuration:
    • Add PRESIGNED_URL_EXPIRATION to Settings in config.py, defaulting to 24 hours (60 * 60 * 24 seconds).

This description was created by Ellipsis for 95274f2. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 95274f2 in 9 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/config.py:64
  • Draft comment:
    Ensure that the default value for PRESIGNED_URL_EXPIRATION is appropriate for your use case. While 24 hours is a common default, consider whether this duration aligns with your security and operational requirements.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change introduces a new configuration setting for presigned URL expiration. This is a straightforward addition, but it's important to ensure that the default value is appropriate and secure.

Workflow ID: wflow_IC19LOPsWRNnxJB5


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit f6d7f36 into main Dec 3, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/fix_PRESIGNED_URL_EXPIRATION branch December 3, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant