Clicking on task title should navigate into task #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Adds `onClick` event to task title in `WorkflowBlockCollapsibleContent.tsx` for navigation. > > - **Behavior**: > - Adds `onClick` event to `TableCell` in `WorkflowBlockCollapsibleContent.tsx` to navigate to task details when task title is clicked. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 3a6c5f9e6eeca5cb3ffa865480be9dfd1af82cf2. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on d8ebf99 in 7 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowBlockCollapsibleContent.tsx:82
- Draft comment:
TheonClickevent handler is repeated across multipleTableCellcomponents. Consider extracting it into a separate function to avoid redundancy and improve maintainability. - Reason this comment was not posted:
Confidence changes required:50%
The onClick event is repeated across multiple TableCell components, which can be refactored to avoid redundancy.
Workflow ID: wflow_rVJ2dOfWKotDZZns
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d8ebf99 in 8 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowBlockCollapsibleContent.tsx:82
- Draft comment:
TheonClickevent handler is repeated across multipleTableCellcomponents. Consider refactoring to a separate function to avoid redundancy. - Reason this comment was not posted:
Confidence changes required:50%
The onClick event handler is repeated across multiple TableCell components, which can be refactored to avoid redundancy.
Workflow ID: wflow_2BKlT340SB5tnKKD
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
deleted the
salih/click-on-task-title-doesnt-navigate-into-task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds
onClickevent to task title inWorkflowBlockCollapsibleContent.tsxfor navigation to task details.onClickevent toTableCellinWorkflowBlockCollapsibleContent.tsxto navigate to task details when task title is clicked.This description was created by
for d8ebf99. It will automatically update as commits are pushed.