Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jinja template for workflow parameter #1272

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 27, 2024

Important

Adds Jinja template rendering for workflow parameters in BaseTaskBlock to support dynamic parameter values.

  • Behavior:
    • Adds format_task_block_parameter_template_from_workflow_run_context() to BaseTaskBlock for Jinja template rendering of parameters.
    • Applies template rendering to url, totp_identifier, download_suffix, navigation_goal, data_extraction_goal, complete_criterion, and terminate_criterion in execute() method of BaseTaskBlock.

This description was created by Ellipsis for 472f312. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 472f312 in 47 seconds

More details
  • Looked at 55 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:220
  • Draft comment:
    Consider making format_task_block_parameter_template_from_workflow_run_context an instance method to avoid passing self attributes repeatedly.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The method format_task_block_parameter_template_from_workflow_run_context is static and is used multiple times in the execute method. It could be made an instance method to avoid passing self attributes repeatedly.

Workflow ID: wflow_hHl27rmZ8uFxDBU4


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 8760b96 into main Nov 27, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/use-jinja-template-format-workflow-parameter branch November 27, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant